Allow overriding the fetch size for a Query #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows true lazy loading of a ResultSet
|
Hello, thank you for PR, we'll merge it soon, but don't you think that it's worth to add the possibility to provide default fetchSize for all queries and keep the ability to override it on single Query? For example, add a parameter on Database instance? |
|
It probably would make sense to set a default - but I'm not sure what that default should be. PostgreSQL itself defaults to 0, which means "cache the entire response". |
Tapac
pushed a commit
that referenced
this pull request
Sep 29, 2018
* Allow overriding the fetch size for a Query * Allow setting default fetch size in Database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At lest in PostgreSQL, the result set from a select() does not appear to be fetched lazily, and PostgreSQL seems to be caching the entire ResultSet.
After this change,
In this test case case, it reduces memory usage by approximately 1.3gb.